Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SpikeDetectConfig, remove SpikeDetectOptions #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Simplify SpikeDetectConfig, remove SpikeDetectOptions #19

wants to merge 3 commits into from

Conversation

emmazhou
Copy link
Contributor

@emmazhou emmazhou commented Sep 24, 2024 •
edited
Loading

Note that this will merge conflict with #18 which is also currently in flight; whatever order they land in, we should end up with:

message SpikeDetectConfig {
  oneof config {
    Thresholder thresholder = 1;
    TemplateMatcher template_matcher = 2;
  }
  uint32 bin_size_ms = 5;
}

@emmazhou emmazhou requested a review from maxhodak September 24, 2024 16:20
@antoniaelsen
Copy link
Collaborator

just ping me when you merge, I will update cpp and ts

@emmazhou emmazhou changed the title simplify SpikeDetectConfig, remove SpikeDetectOptions Simplify SpikeDetectConfig, remove SpikeDetectOptions Oct 1, 2024
@antoniaelsen
Copy link
Collaborator

Do we still want this @emmazhou ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniaelsen antoniaelsen antoniaelsen approved these changes

@maxhodak maxhodak Awaiting requested review from maxhodak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmazhou @antoniaelsen